"Solo_on" light Midi Out Novation Launchpad S

Errors, malfunctions, website typos.
djMo
F6 - Feverfew
Posts: 9
Joined: Tue Sep 04, 2018 9:28 am

"Solo_on" light Midi Out Novation Launchpad S

Post by djMo » Sun Sep 09, 2018 1:32 pm

Hi there.

I cant get midi out light to work on Novation Launchpad S. I get playing and mute to work fine but solo just won't.....

User avatar
FFT
F14 - Syrian Rue
Posts: 512
Joined: Thu Mar 08, 2012 6:51 pm

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by FFT » Mon Sep 10, 2018 8:13 pm

Hey,

Could you please paste here your current midimap JSON? Thanks!

djMo
F6 - Feverfew
Posts: 9
Joined: Tue Sep 04, 2018 9:28 am

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by djMo » Fri Sep 14, 2018 12:38 pm

{
"brand": "Novation",
"device": "Launchpad S",
"init_commands": [
{
"channel": 0,
"message": "0xB0000000"
},
{
"channel": 0,
"message": "0xB0002800"
}
],
"mute_on": {
"channel": 0,
"message": "0x90nn0B00"
},
"mute_off": {
"channel": 0,
"message": "0x90nn0C00"
},
"solo_on": {
"channel": 0,
"message": "0x90nn0B00"
},
"solo_off": {
"channel": 0,
"message": "0x90nn0B00"
},
"waiting": {
"channel": 0,
"message": "0x90nn7f00"
},
"playing": {
"channel": 0,
"message": "0x90nn3C00"
},
"stopping": {
"channel": 0,
"message": "0x90nn0B00"
},
"stopped": {
"channel": 0,
"message": "0x90nn0C00"
}
}

djMo
F6 - Feverfew
Posts: 9
Joined: Tue Sep 04, 2018 9:28 am

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by djMo » Fri Oct 12, 2018 5:39 pm

any ideas yet?

User avatar
FFT
F14 - Syrian Rue
Posts: 512
Joined: Thu Mar 08, 2012 6:51 pm

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by FFT » Sun Oct 14, 2018 12:11 pm

Sorry, no clue so far :? Unfortunately we don't have a physical Launchpad S in our labs, so I can only speculate. The JSON looks right. Just to make sure there's not a bug in the code: what happens if you trigger another message (e.g. the "playing" one 0x90nn3C00) on solo_on or solo_off?

mctom
F8 - Hawthorn
Posts: 23
Joined: Sat Oct 06, 2018 1:19 pm
Location: Gdansk, Poland

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by mctom » Sun Oct 14, 2018 2:15 pm

FFT wrote:
Sun Oct 14, 2018 12:11 pm
The JSON looks right.
Does it? It seems that it sends out the same message on solo_on and solo_off.
Incidentally, that message is meant for blinking red color, so it should blink red all the time.
I'd suggest going back to original giadamap file.
But then again, this certainly won't solve the problem. I observe similar effect on my Launchpad Mini.

I've JACKed in the midi sniffer into the Giada MIDI output and I can confirm that Giada doesn't send any MIDI messages on solo_on and solo_off events.

mctom
F8 - Hawthorn
Posts: 23
Joined: Sat Oct 06, 2018 1:19 pm
Location: Gdansk, Poland

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by mctom » Tue Oct 16, 2018 6:46 pm

Yup, function void Channel::sendMidiLmute() is defined but never invoked in the project. I'll see if I can fix it, but no promises.

User avatar
FFT
F14 - Syrian Rue
Posts: 512
Joined: Thu Mar 08, 2012 6:51 pm

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by FFT » Thu Oct 18, 2018 6:57 pm

Ha, good catch! I can confirm that sendMidiLmute() is never called anywhere. It seems the whole solo part fell under the radar during the last channel refactoring. If you really want to get your hands dirty: you could add a new method similar to Channel::setMute(), following the same pattern. BTW I'm going to open a new issue on github, thanks!

mctom
F8 - Hawthorn
Posts: 23
Joined: Sat Oct 06, 2018 1:19 pm
Location: Gdansk, Poland

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by mctom » Thu Oct 18, 2018 7:05 pm

FFT wrote:
Thu Oct 18, 2018 6:57 pm
you could add a new method similar to Channel::setMute()
Actually this is exactly what I did a few hours ago. I started working on my own ideas from MIDI Enhancements so it made perfect sense to fix that as well. I'll report back with my progress this weekend, hopefully. :)

mctom
F8 - Hawthorn
Posts: 23
Joined: Sat Oct 06, 2018 1:19 pm
Location: Gdansk, Poland

Re: "Solo_on" light Midi Out Novation Launchpad S

Post by mctom » Fri Oct 19, 2018 7:12 pm

Pheeeeew! I set up a git account, made a fork, and sorted out all that witchcraft to make a future pull request possible.

And yeah, I fixed solo lightning issues just like FFT suggested. I've spent 2 hours wondering why it's not working. It turned out I constantly compiled the whole thing with one file outside core dir outdated. :D

The problem is that this fix is a part of a bigger thing. I've made a feature I wanted to see in Giada myself - playing_inaudible giadamap parameter, for alternative channel lightning when it's muted or soloed out. This is all done and this is awesome on launchpad! I use dimmed green for playing_inaudible and now lightning makes way more sense.
For the sake of backward compatibility, I'll make all giadamap parameters optional (i.e. do nothing when no message is specified). Then, I think, this will be ready for pull request.

Post Reply